add macros for tapir codegen #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsimpson
deleted the
add_macros_to_fix_tapir_codegen_compilation_flakiness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macros appear, almost magically, to be sufficient for test cases that were previously breaking under compilation (cf issue and reproduction) to successfully compile. I understand why the first two help, but I am somewhat more mystified as to why the ADT ones work where the default
makemacro call does not, since both still use eval. I am, however, not prepared to look the gift horse in the mouth, and if you're happy to have these in the codebase @plokhotnyuk that would really do some wonders for CI flakiness 😅Even with 26 identical modules I get no compilation errors, and 8 was sufficient for 100% local failure rate without the changes. I am certain this is working around a Scala compiler bug, but how to solve that more generally within the
makemacro appears to be beyond me - and I have tried a lot of alternatives at this point.