Skip to content

Translate game #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

yhjsoar
Copy link

@yhjsoar yhjsoar commented Dec 10, 2018

We translated the game to Korean and add function to select English or Korean from the first start screen.

@cawvyoct
Copy link
Collaborator

Thanks for the PR and interest in the project! 👍
Leaving an update message to say that we are assessing the PR.
We will get back to you soon on an update on what actions will come next. 🐈

@cawvyoct
Copy link
Collaborator

✍️ We like this PR because multi-language support is important to us. 🗺️

We are trying to refactor the project right now to make it easier for PRs like this one to start adding multiple languages to the project.
Please note however that adding multiple languages into C++ projects is quite a challenge. We are thinking of ways to support the feature so that it is easy for anyone to add new languages quickly. 🕊️

@cawvyoct
Copy link
Collaborator

cawvyoct commented Dec 13, 2018

Currently, we have come to the decision that using hard-coded if() statements blocks would not be a wise method of supporting multiple languages.

This is because:

  • it will be difficult to scale (for 10+ languages)
  • the code needed will be difficult to support in the projects' lifecycle after long periods of time.

@cawvyoct
Copy link
Collaborator

This PR will not be merged and will be closed as it does not fit the answer the project needs right now.

However, it is great that you brought it to our attention! 🎉
It is exciting to see that this game is being played around the world so thank you for your contribution! 🗺️

I have made a new issue (#89) and have used this PR as reference.
It will help in finding a solution to the hurdle, ok?
Thanks! 😄 👍

@cawvyoct cawvyoct closed this Dec 13, 2018
@yhjsoar
Copy link
Author

yhjsoar commented Dec 14, 2018

Thank You for your answer! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants