Skip to content

feat: Don't mount service account token by deault #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Don't mount service account token by deault #23

wants to merge 1 commit into from

Conversation

lotooo
Copy link
Member

@lotooo lotooo commented Apr 28, 2025

There is no reason to mount the SA token by default.

Just in case, I moved it to a parameter with a default value of false

@lotooo lotooo requested a review from MarshallAsch April 28, 2025 21:26
MarshallAsch
MarshallAsch approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@MarshallAsch MarshallAsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me, I vuagly recall Gaston saying something about this tho

@cilindrox
Copy link
Member

Seems like the chart can't be installed at all?

sh: server.js: unknown operand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cilindrox cilindrox cilindrox approved these changes

@MarshallAsch MarshallAsch MarshallAsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lotooo @cilindrox @MarshallAsch