Skip to content
This repository has been archived by the owner on Nov 24, 2017. It is now read-only.

Removed incorrect role attribute on popoverDiv #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lex-rmondal
Copy link

@lex-rmondal
Copy link
Author

What are the issues solved by that?

Maybe, you should send a PR to the maintained fork at https://github.com/virtualidentityag/ng2-popover

Hey @koppor, do you publish your fork in npm? I need a published version of this repository.

Coming to the changes, role = "popover" is an invalid role attribute which will cause accessibility issue when using screen reader.

@koppor
Copy link

koppor commented Apr 7, 2017

No, I have no intentions to publish my fork (@koppor). Could you talk to @virtualidentityag? I assume, he is open to publish it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants