[2.9.x] Pin Play 2.9 updates #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihostage
force-pushed
the
steward-message-29x
branch
from
b105a1b to
852ea24
Compare
mkurz
reviewed
Jan 15, 2024
|
|
||
| updates.pin = [ | ||
| // Play 2.9 | ||
| { groupId = "com.typesafe.play", artifactId = "sbt-plugin", version = "2.9" }, |
There was a problem hiding this comment.
Ops, too fast, seems the version need to have a . as suffix: https://github.com/scala-steward-org/scala-steward/blob/main/docs/faq.md#how-can-version-updates-be-controlled
So here it should be 2.9. not just 2.9...
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm 🤔 Will this config not work without ending .? Or it's just possible to get PR with bump to 2.90.0? 😄
There was a problem hiding this comment.
To be honest I did not check if it is working or not, I just saw that in the docs and also in our other repos we always add . at the end, so I think if we know this is working we probably keep it that way. Maybe it also works without the dot... I don't know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.