Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump play 284 #116

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Bump play 284 #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a683d0
Adds a script to do a quick and dirty run of the samples locally
ignasi35 Nov 5, 2020
5acf20a
Bumps play to 2.8.4
ignasi35 Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions local-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#!/usr/bin/env bash

pushd play-java-chatroom-example && scripts/test-sbt && popd
pushd play-java-compile-di-example && scripts/test-sbt && popd
pushd play-java-dagger2-example && scripts/test-sbt && popd
pushd play-java-ebean-example && scripts/test-sbt && popd
pushd play-java-fileupload-example && scripts/test-sbt && popd
pushd play-java-forms-example && scripts/test-sbt && popd
pushd play-java-grpc-example && scripts/test-sbt && popd
pushd play-java-hello-world-tutorial && scripts/test-sbt && popd
pushd play-java-jpa-example && scripts/test-sbt && popd
pushd play-java-rest-api-example && scripts/test-sbt && popd
pushd play-java-starter-example && scripts/test-sbt && popd
pushd play-java-streaming-example && scripts/test-sbt && popd
pushd play-java-websocket-example && scripts/test-sbt && popd
pushd play-java-akka-cluster-example && scripts/test-sbt && popd
pushd play-scala-anorm-example && scripts/test-sbt && popd
pushd play-scala-chatroom-example && scripts/test-sbt && popd
pushd play-scala-compile-di-example && scripts/test-sbt && popd
pushd play-scala-fileupload-example && scripts/test-sbt && popd
pushd play-scala-forms-example && scripts/test-sbt && popd
pushd play-scala-grpc-example && scripts/test-sbt && popd
pushd play-scala-hello-world-tutorial && scripts/test-sbt && popd
pushd play-scala-isolated-slick-example && scripts/test-sbt && popd
pushd play-scala-log4j2-example && scripts/test-sbt && popd
pushd play-scala-macwire-di-example && scripts/test-sbt && popd
pushd play-scala-rest-api-example && scripts/test-sbt && popd
# Uses libsodium
# pushd play-scala-secure-session-example && scripts/test-sbt && popd
pushd play-scala-slick-example && scripts/test-sbt && popd
pushd play-scala-starter-example && scripts/test-sbt && popd
pushd play-scala-streaming-example && scripts/test-sbt && popd
# uses vanilla sbt
# pushd play-scala-tls-example && scripts/test-sbt && popd
pushd play-scala-websocket-example && scripts/test-sbt && popd
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sneaking this one in as an early attempt to quickly run samples locally for faster diagnosis in case of regression.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add something like https://github.com/akka/akka-platform-guide/blob/main/scripts/format-all.sh and even remove the separate Travis jobs.
WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add something like https://github.com/akka/akka-platform-guide/blob/main/scripts/format-all.sh and even remove the separate Travis jobs.
WDYT?

Hmm, yeah, simplifying this code is a good idea.

I'm not sure about running all tests in a single travis job. Every once in a while there's a failure here or there and having separate jobs makes it faster to diagnose. Let's merge this as is and discuss improvements in a new issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raised #118

2 changes: 1 addition & 1 deletion play-java-akka-cluster-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-java-chatroom-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-java-compile-di-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-java-dagger2-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-java-ebean-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

addSbtPlugin("com.typesafe.sbt" % "sbt-play-ebean" % "5.0.2")
2 changes: 1 addition & 1 deletion play-java-fileupload-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-java-forms-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-java-grpc-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ val playGrpcV = "0.9.1"
buildInfoKeys := Seq[BuildInfoKey]("playGrpcVersion" -> playGrpcV)
buildInfoPackage := "play.java.grpc.sample"

addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

// #grpc_sbt_plugin
// project/plugins.sbt
Expand Down
2 changes: 1 addition & 1 deletion play-java-hello-world-tutorial/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-java-jpa-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

// Web plugins
addSbtPlugin("com.typesafe.sbt" % "sbt-coffeescript" % "1.0.2")
Expand Down
2 changes: 1 addition & 1 deletion play-java-rest-api-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

// Load testing tool:
// http://gatling.io/docs/2.2.2/extensions/sbt_plugin.html
Expand Down
2 changes: 1 addition & 1 deletion play-java-starter-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-java-streaming-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// Use the Play sbt plugin for Play projects
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-java-telemetry-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

addSbtPlugin("com.lightbend.cinnamon" % "sbt-cinnamon" % "2.12.4")

Expand Down
2 changes: 1 addition & 1 deletion play-java-websocket-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

addSbtPlugin("com.typesafe.sbt" % "sbt-less" % "1.1.2")

Expand Down
2 changes: 1 addition & 1 deletion play-scala-anorm-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-chatroom-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-compile-di-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-fileupload-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ resolvers += Resolver.typesafeRepo("snapshots")
resolvers += Resolver.jcenterRepo

// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-forms-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-grpc-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildInfoKeys := Seq[BuildInfoKey]("playGrpcVersion" -> playGrpcV)
buildInfoPackage := "play.scala.grpc.sample"


addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

// #grpc_sbt_plugin
// project/plugins.sbt
Expand Down
2 changes: 1 addition & 1 deletion play-scala-hello-world-tutorial/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-isolated-slick-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ addSbtPlugin("io.github.davidmweber" % "flyway-sbt" % "6.2.2")
addSbtPlugin("com.github.tototoshi" % "sbt-slick-codegen" % "1.4.0")

// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-log4j2-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-macwire-di-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-rest-api-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

// sbt-paradox, used for documentation
addSbtPlugin("com.lightbend.paradox" % "sbt-paradox" % "0.4.4")
Expand Down
2 changes: 1 addition & 1 deletion play-scala-secure-session-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-slick-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-starter-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-streaming-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// Use the Play sbt plugin for Play projects
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-telemetry-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

addSbtPlugin("com.lightbend.cinnamon" % "sbt-cinnamon" % "2.12.4")

Expand Down
2 changes: 1 addition & 1 deletion play-scala-tls-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// The Play plugin
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")
2 changes: 1 addition & 1 deletion play-scala-websocket-example/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Use the Play sbt plugin for Play projects
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.3")
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.4")

addSbtPlugin("com.typesafe.sbt" % "sbt-less" % "1.1.2")

Expand Down