Fix clicking on disabled menuitems (#142)

* Fix bug where clicking on disabled menuitem would trigger click on its parent menu item

* Update version

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@playcanvas/pcui",
-  "version": "2.2.2",
+  "version": "2.2.3",
   "author": "PlayCanvas <[email protected]>",
   "homepage": "https://playcanvas.github.io/pcui",
   "description": "This library enables the creation of reliable and visually pleasing user interfaces by providing fully styled components that you can use directly on your site. The components are useful in a wide range of use cases, from creating simple forms to building graphical user interfaces for complex web tools.",

src/MenuItem/index.js

@@ -61,7 +61,8 @@ class MenuItem extends Container {
 
         this.text = args.text || 'Untitled';
 
-        this.on('click', this._onClickMenuItem.bind(this));
+        this._domEvtMenuItemClick = this._onClickMenuItem.bind(this);
+        this.dom.addEventListener('click', this._domEvtMenuItemClick);
 
         if (args.value) {
             this.value = args.value;
@@ -111,7 +112,9 @@ class MenuItem extends Container {
     _onClickMenuItem(evt) {
         evt.preventDefault();
         evt.stopPropagation();
-        this.select();
+        if (!this.disabled) {
+            this.select();
+        }
     }
 
     link(observers, paths) {
@@ -140,6 +143,14 @@ class MenuItem extends Container {
         }
     }
 
+    destroy() {
+        if (this.destroyed) return;
+
+        this.dom.removeEventListener('click', this._domEvtMenuItemClick);
+
+        super.destroy();
+    }
+
     get text() {
         return this._labelText.text;
     }