- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.5k
Fix memory leak on mesh collider destroy #5106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 7 commits
      Commits
    
    
            Show all changes
          
          
            28 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      8f7277c
              
                Added `destroyShape` function to global system
              
              
                MushAsterion 316a86b
              
                Use of `destroyShape`
              
              
                MushAsterion 4ea6669
              
                Fixed shape destruction on `recreatePhysicalShapes`
              
              
                MushAsterion 319db04
              
                Reverted extra line deleted
              
              
                MushAsterion f44ba06
              
                Made shape null in `destroyShape`
              
              
                MushAsterion bd9e9c3
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 3c218f5
              
                Added Ammo for testing modules requiring Ammo to work
              
              
                MushAsterion 2852b57
              
                Added test for shape colliders destruction on collision component des…
              
              
                MushAsterion 201702e
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 568092a
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 7214116
              
                Remove not relevant anymore comment
              
              
                MushAsterion 26bab08
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion fc96352
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion d3c3fa3
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion c49c6d4
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 69c76fa
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion f600f9c
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion d98bbf0
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion aaaf03e
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 7b3b582
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 1a3b862
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 609ecd8
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 9f8e0ac
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 8988b26
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion fb1eeaf
              
                Shortened shape destroying
              
              
                MushAsterion 3deec39
              
                Merge branch 'playcanvas:main' into fix-mesh-collider
              
              
                MushAsterion 3f6767f
              
                Remove Ammo tests
              
              
                MushAsterion 83f7992
              
                Remove Ammo tests
              
              
                MushAsterion File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.