Preserve comments in platformio.ini on save (guarded helper + test) — fixes #3862 #5249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please anyone review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds save_ini_preserving_comments, a guarded INI writer that uses ConfigUpdater to round-trip platformio.ini while preserving comments and inline notes, with fallback to ConfigParser if import/parsing fails. This introduces a safe, optional capability (tested with header/inline comments) without altering existing code paths; adoption at call sites (e.g., ProjectConfig.save() or Home configurator) is up to maintainers. Resolves #3862.