PR to run CI pipeline #893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| accum = bytes() | ||
| for i in range(31): | ||
| accum += bytes(2 * 10485767) # 2x the allocation sampling window | ||
| bogus = None |
Check notice
Code scanning / CodeQL
Unused local variable Note test
| import subprocess | ||
| import tempfile | ||
| import sys | ||
| from typing import List |
Check notice
Code scanning / CodeQL
Unused import Note test
Comment on lines
+84
to
+87
| # for stem, profile in [one_alloc, two_on_one_line, line_after_final_alloc]: | ||
| # line = get_line(profile, LOOP_ALLOC_LINENO) | ||
| # if not line.n_mallocs == N_LOOPS: | ||
| # errors.append(f"Expected {N_LOOPS} distinct lines on {stem}, got {line.n_mallocs} on line {LOOP_ALLOC_LINENO}") |
Check notice
Code scanning / CodeQL
Commented-out code Note test
Comment on lines
+91
to
+97
| # if not bt_line.n_mallocs < N_LOOPS: | ||
| # errors.append(f"{bt_stem} makes smaller allocations than the allocation sampling window, so fewer than {N_LOOPS} allocations on {LOOP_ALLOC_LINENO} should be reported. Got {bt_line.n_mallocs} mallocs") | ||
|
|
||
| # for stem, profile in [one_alloc, two_on_one_line, below_threshold, line_after_final_alloc]: | ||
| # line = get_line(profile, OUT_OF_LOOP_ALLOC_LINENO) | ||
| # if not line.n_mallocs == 1: | ||
| # errors.append(f'Line {OUT_OF_LOOP_ALLOC_LINENO} in {stem} makes a large allocation, so it should be reported.') |
Check notice
Code scanning / CodeQL
Commented-out code Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.