Skip to content

Conversation

@jdoupe
Copy link

@jdoupe jdoupe commented Sep 17, 2025

Addresses #719

@jdoupe jdoupe force-pushed the add-vtbackup-extraflags branch 2 times, most recently from 2a84146 to 2008e1e Compare September 22, 2025 13:47
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, thank you. Could you add a test for this please?

Signed-off-by: Jeremy Doupe <[email protected]>
Signed-off-by: Jeremy Doupe <[email protected]>
@jdoupe jdoupe force-pushed the add-vtbackup-extraflags branch from 2008e1e to 89242c4 Compare September 24, 2025 03:04
@jdoupe
Copy link
Author

jdoupe commented Sep 24, 2025

This is a good start, thank you. Could you add a test for this please?

I added a test. Not a lot of examples to work with, and also wasn't really able to execute on my laptop, so hopefully it works well. I may have to work on an alternate development / test environment if it has issues.

Resolved comments. Made things a bit cleaner. Thank you.

@jdoupe jdoupe requested a review from frouioui September 30, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants