fix overwrite of cluster-level default images #713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #710, when a keyspace had keyspace-level image definition in its spec, it would overwirte the cluster-level image definition for any subsequent keyspaces.
This PR fixes #710 by doing a deep copy of the cluster-level image before assigning them to the keyspace.
This PR should be backported to all supported release branches.
To give more context, these two lines were conflicting:
Where
DefaultVitessKeyspaceImageswas assigning theVitessKeyspaceImages.Mysqldpointer of the cluster-level images to the keyspace-level, and then inMergeVitessKeyspaceTemplateImageswe were modifying the value behind the pointer by the keyspace-specific image.