Skip to content

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Jul 30, 2025

As reported in #710, when a keyspace had keyspace-level image definition in its spec, it would overwirte the cluster-level image definition for any subsequent keyspaces.

This PR fixes #710 by doing a deep copy of the cluster-level image before assigning them to the keyspace.

This PR should be backported to all supported release branches.


To give more context, these two lines were conflicting:

	planetscalev2.DefaultVitessKeyspaceImages(&images, &vt.Spec.Images)

	// Apply user-defined overrides for images.
	planetscalev2.MergeVitessKeyspaceTemplateImages(&images, &keyspace.Images)

Where DefaultVitessKeyspaceImages was assigning the VitessKeyspaceImages.Mysqld pointer of the cluster-level images to the keyspace-level, and then in MergeVitessKeyspaceTemplateImages we were modifying the value behind the pointer by the keyspace-specific image.

Signed-off-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: Keyspace-Level Image Settings Issue in Vitess Operator

2 participants