Change the want list to work in on demand mode #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change the Swift code can request blobs to be downloaded and the blobs remain in the want list for a specific amount of time. This replace the previous approach of downloading all blobs right away and copies the current behaviour exhibited by go-ssb. The new code behaves slightly better as the want list isn't cleared when application exists and is persisted.
boreq
force-pushed
the
on-demand-want-list
branch
from
5b682bc to
977a59e
Compare
boreq
changed the title
boreq
commented
Jul 4, 2022
czeslavo
reviewed
Jul 5, 2022
Comment on lines
+124
to
+127
| if now.After(until) { | ||
| toDelete = append(toDelete, id) | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I'm wondering if we could somehow make the cleanup part independent to make reads faster. Maybe we should not care about cleaning up at this point and add it later as an independent process, along with removing blobs from the disk?
There was a problem hiding this comment.
Or we can leave it as it is for now, and add a point to #1 to take care of it later.
There was a problem hiding this comment.
I added a point to #1 already as I think this is good enough for now as it "kinda works" but I definitely want to fix this soon.
Co-authored-by: Grzegorz Burzyński <[email protected]>
Co-authored-by: Grzegorz Burzyński <[email protected]>
boreq
added a commit
that referenced
this pull request
Jul 5, 2022
After this change the Swift code can request blobs to be downloaded and the blobs remain in the want list for a specific amount of time. This replace the previous approach of downloading all blobs right away and copies the current behaviour exhibited by go-ssb. The new code behaves slightly better as the want list isn't cleared when application exists and is persisted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change the Swift code can request blobs to be downloaded and
the blobs remain in the want list for a specific amount of time. This
replace the previous approach of downloading all blobs right away and
copies the current behaviour exhibited by go-ssb. The new code behaves
slightly better as the want list isn't cleared when application exists
and is persisted.