Implementing built in date formatting #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the number.Format method doesn't take into consideration the formatting code. This diff implements formatting for dates based on the code. The implementation doesn't look at the cell data type because in cases of date it's not being populated by Excel, so it's always empty.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 63.49% 63.10% -0.39%
==========================================
Files 100 100
Lines 4005 3288 -717
==========================================
- Hits 2543 2075 -468
+ Misses 1417 1169 -248
+ Partials 45 44 -1 ☔ View full report in Codecov by Sentry. |
|
I can't approve these changes, since it changes defaults from the official docs for XLSX. I probably will use this PR as a reference when I will have time to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the number.Format method doesn't take into consideration the formatting code. This diff implements formatting for dates based on the code.
The implementation doesn't look at the cell data type because in cases of date it's not being populated by Excel, so it's always empty.