Protect expired URL codes #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the URL code expiration functionality to prevent expired codes from being reused and making old events inaccessible. The change ensures that once a URL code is assigned to an event, it remains permanently associated with that event.
Key Changes:
- Removed automatic cleanup of expired URL codes from scheduled tasks
- Changed URL code creation from
update_or_createtocreateto prevent overwriting existing codes - Simplified code availability checking to reject all existing codes regardless of age
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| api/tasks.py | Removed url_code_cleanup() function and its invocation from daily tasks, along with related imports |
| api/event/views.py | Changed from update_or_create to create when assigning URL codes to new events, preventing code reuse |
| api/event/utils.py | Simplified check_code_available() to reject any existing code instead of only non-expired ones |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we haven't figured out a solution for dealing with expired URL codes and archiving events. Because of this, if a URL code was re-used it would make the old event it referenced inaccessible.
In addition, we haven't told the users anywhere on the website that the URL codes expire and can be "stolen". Because of this, the functionality is being removed from the backend for now to avoid confusion and frustration.