Open
Conversation
morita-kuma
commented
Sep 28, 2015
morita-kuma
commented
- updated to 2.7.3 from 2.4.2
- replace a deplicated method
added 4 commits
September 28, 2015 14:49
modified: src/main/scala/sedis.scala
This reverts commit ae21752.
Collaborator
|
Hi, can you squash the commits modifying the pom.xml please? Other than that, looks good to me. |
Collaborator
|
@moli9ma can you rebase this on the latest master please? |
src/main/scala/sedis.scala
Outdated
| def get(k: String): Option[String] = { | ||
| val f = j.get(k) | ||
| if (f == null) None else Some(f) | ||
| Option(j.get(k)) |
Collaborator
There was a problem hiding this comment.
this is an unrelated fix, can you move it to another PR
Author
There was a problem hiding this comment.
I will send this as another PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.