Add more linter to golangci-lint

- Add a configuration file for golangci-lint
- Add `gofmt`, `goimports`, `errcheck` and `golint` linters
- Fixes code accordingly

Signed-off-by: Vincent Demeester <[email protected]>

.errcheck.txt

@@ -0,0 +1,8 @@
+(*github.com/tektoncd/pipeline/vendor/go.uber.org/zap.SugaredLogger).Sync
+flag.Set
+os.Setenv
+logger.Sync
+fmt.Fprintf
+fmt.Fprintln
+(io.Closer).Close
+updateConfigMap

.golangci.yml

@@ -0,0 +1,14 @@
+run:
+  build-tags:
+  - e2e
+  skip-dirs:
+  - vendor
+linters-settings:
+  errcheck:
+    exclude: .errcheck.txt
+linters:
+  enable:
+    - gofmt
+    - goimports
+    - errcheck
+    - golint

cmd/docs/generate.go

@@ -76,7 +76,9 @@ func loadLongDescription(cmd *cobra.Command, path ...string) error {
 		}
 		fullpath := filepath.Join(path[0], strings.Join(append(path[1:], cmd.Name()), "_")+".md")
 		if cmd.HasSubCommands() {
-			loadLongDescription(cmd, path[0], cmd.Name())
+			if err := loadLongDescription(cmd, path[0], cmd.Name()); err != nil {
+				return err
+			}
 		}
 
 		if _, err := os.Stat(fullpath); err != nil {

cmd/docs/md_docs.go

@@ -45,11 +45,6 @@ func printOptions(buf *bytes.Buffer, cmd *cobra.Command, name string) error {
 	return nil
 }
 
-// GenMarkdown creates markdown output.
-func GenMarkdown(cmd *cobra.Command, w io.Writer) error {
-	return GenMarkdownCustom(cmd, w, func(s string) string { return s })
-}
-
 // GenMarkdownCustom creates custom markdown output.
 func GenMarkdownCustom(cmd *cobra.Command, w io.Writer, linkHandler func(string) string) error {
 	cmd.InitDefaultHelpCmd()

pkg/cmd/completion/completion.go

@@ -62,7 +62,7 @@ func Command() *cobra.Command {
 // runCompletionZsh generate completion manually, we are not using cobra
 // completion since it's not flexible enough for us.
 func runCompletionZsh(out io.Writer, tkn *cobra.Command) error {
-	if _, err := out.Write([]byte(zsh_completion)); err != nil {
+	if _, err := out.Write([]byte(zshCompletion)); err != nil {
 		return err
 	}
 	return nil

pkg/cmd/completion/zsh_completion.go

@@ -1,6 +1,6 @@
 package completion
 
-var zsh_completion = `
+var zshCompletion = `
 #compdef _tkn tkn
 local -a common_options common_describe_options common_logs_options
 

pkg/cmd/pipelinerun/log_writer.go

@@ -16,6 +16,7 @@ package pipelinerun
 
 import (
 	"fmt"
+
 	"github.com/tektoncd/cli/pkg/cli"
 	"github.com/tektoncd/cli/pkg/formatted"
 )

pkg/cmd/pipelinerun/logs.go

@@ -16,11 +16,11 @@ package pipelinerun
 
 import (
 	"fmt"
-	"github.com/tektoncd/cli/pkg/helper/pods/stream"
 
 	"github.com/spf13/cobra"
 	"github.com/tektoncd/cli/pkg/cli"
 	"github.com/tektoncd/cli/pkg/helper/pods"
+	"github.com/tektoncd/cli/pkg/helper/pods/stream"
 )
 
 const (

pkg/cmd/taskrun/log_writer.go

@@ -16,6 +16,7 @@ package taskrun
 
 import (
 	"fmt"
+
 	"github.com/tektoncd/cli/pkg/cli"
 	"github.com/tektoncd/cli/pkg/formatted"
 )

pkg/cmd/version/version.go

@@ -76,7 +76,7 @@ func checkRelease(outStream io.Writer) error {
 
 	var response struct {
 		TagName string `json:"tag_name"`
-		HtmlUrl string `json:"html_url"`
+		HTMLURL string `json:"html_url"`
 	}
 	if err := json.Unmarshal(body, &response); err != nil {
 		return errors.Wrap(err, "failed to unmarshal the latest version response body")
@@ -93,7 +93,7 @@ func checkRelease(outStream io.Writer) error {
 	}
 
 	if current.LT(*latest) {
-		fmt.Fprintf(outStream, "A newer version (v%s) of Tekton CLI is available, please check %s\n", latest, response.HtmlUrl)
+		fmt.Fprintf(outStream, "A newer version (v%s) of Tekton CLI is available, please check %s\n", latest, response.HTMLURL)
 	} else {
 		fmt.Fprintf(outStream, "You are running the latest version (v%s) of Tekton CLI\n", latest)
 	}

pkg/formatted/color.go

@@ -15,8 +15,9 @@
 package formatted
 
 import (
-	"github.com/fatih/color"
 	"io"
+
+	"github.com/fatih/color"
 )
 
 //Color formatter to print the colored output on streams

pkg/helper/pods/container.go

@@ -17,8 +17,9 @@ package pods
 import (
 	"bufio"
 	"fmt"
-	"github.com/tektoncd/cli/pkg/helper/pods/stream"
 	"io"
+
+	"github.com/tektoncd/cli/pkg/helper/pods/stream"
 	corev1 "k8s.io/api/core/v1"
 )