Version Catalog の導入 #123
Merged
Version Catalog の導入 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugg003
commented
Oct 11, 2023
| @@ -40,7 +40,6 @@ dependencies { | |||
| implementation deps.androidX.fragment | |||
| implementation deps.androidX.material | |||
| implementation deps.androidX.core | |||
| implementation deps.kotlin.stdlib | |||
There was a problem hiding this comment.
Standard Library の依存関係は、実は細かく指定する必要がないため、この機会に削除しました。
https://kotlinlang.org/docs/gradle-configure-project.html#dependency-on-the-standard-library
yugg003
commented
Oct 11, 2023
| android-application = { id = "com.android.application", version.ref = "android-gradle" } | ||
| android-library = { id = "com.android.library", version.ref = "android-gradle" } | ||
| kotlin = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" } | ||
| kotlin-parcelize = { id = "org.jetbrains.kotlin.plugin.parcelize", version.ref = "kotlin" } |
There was a problem hiding this comment.
id はここを参考に設定しています。
https://plugins.gradle.org/plugin/org.jetbrains.kotlin.plugin.parcelize
|
LGTM |
verno3632
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解決したいこと
やったこと
やらないこと
スクリーンショット
UIに変更が生じた場合はスクショを貼ってください
動作確認環境