fix: Improving exec cleanup

pixeleye-io · Jun 18, 2024 · 6343b8a · 6343b8a
1 parent 06a9e9b
commit 6343b8a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/tasty-dots-peel.md b/.changeset/tasty-dots-peel.md
@@ -0,0 +1,5 @@
+---
+"pixeleye": patch
+---
+
+Improving exec cleanup
diff --git a/integrations/cli/pixeleye/src/handlers/exec.ts b/integrations/cli/pixeleye/src/handlers/exec.ts
@@ -68,7 +68,10 @@ export async function execHandler(
   });
 
   onExitFns.push(async () => {
-    child.kill();
+    child.stdin?.end();
+    child.stdout?.destroy();
+    child.stderr?.destroy();
+    child.kill("SIGKILL");
   });
 
   fileSpinner.succeed("Successfully started local snapshot server.");
@@ -166,7 +169,7 @@ export async function execHandler(
     console.log(`\nBuild status: ${finalStatus}`);
   }
 
-  child.kill();
+  await Promise.all(onExitFns.map((fn) => fn()));
 
   process.exit(0);
 }