Add support for Redis Sentinel HA Setup (#32). #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Tanzu for Valkey on Cloud Foundry supports high-available marketplace offerings, out-of-the box Spring Boot property binding was missing. This change try to implement just that, supporting Sentinel setup either with or without TLS.
|
@scottfrederick Is this something you would like to review? |
|
@garethjevans I'm not sure who maintains this repository nowadays, if you are would you review this change in order to solve #32 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Tanzu for Valkey on Cloud Foundry supports high-available marketplace offerings, out-of-the box Spring Boot property binding was missing. This change try to implement just that, supporting Sentinel setup either with or without TLS.
This implementation is working for me (locally). Please let me know if any test and or quality checks are still required.