Frontend cleanup#42
Conversation
falquaddoomi
left a comment
There was a problem hiding this comment.
Looks good to me! I tried the new tabs feature and the new download options and they all seem to work well.
This isn't something introduced by this PR so I don't think it should block approving it, but I noticed that when you're renaming a figure before it's been auto-captioned, it fires a lot of "Updating figures..." toasts, one per character entered. I assume the toast at least could be debounced, and possibly whatever else is getting triggered when the figure's name changes.
|
@falquaddoomi If you could spot check the latest commit then I can merge. |
falquaddoomi
left a comment
There was a problem hiding this comment.
Just tested it locally with the recent changes, @vincerubinetti, and it's naming the figures correctly initially and responding correctly AFAICT to their names being changed (i.e., if I construct an invalid reference, it doesn't show the figure, but it shows the figure when I update the reference to the figure's slugified name). I like that you added the captions, very cool!
I think it's out of scope for this PR, but perhaps the user should be able to edit the captions and/or have them not appear in case they're not correctly inferred by the LLM. IMO the inferred captions should be a first pass that the user can subsequently edit.
Complete overhaul of frontend code and design, adding new features.
High level overview: