Add basic authentication support for Swagger JSON #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple authentication schemas are supported, for both query and header locations. Security is only applied to the root at this time.
Collaborator
|
IMHO, we should not be making changes to rapidjson. Pistache should change to pull in a read-only copy of rapidjson anyway. Also, your PR lacks any new unit tests to cover the new logic. Please add some appropriate unit tests. |
Member
|
Member
|
Hey @bthrall. Just checking in, but do you still intend to work on this PR? If so, you may want to start by rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple authentication schemas are supported, for both query and header locations.
Security is only applied to the root at this time.