Skip to content

Fix memory leak 267 282 #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amirnik wants to merge 4 commits into from
Closed

Fix memory leak 267 282 #290

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ba82a6
Fix memory leak #267
amirnik Sep 5, 2018
da984d9
Fix Memory leak #282
amirnik Sep 5, 2018
d191058
Fixing memory leak of addrinfo #282
Sep 10, 2018
2f38f1a
Removing direct freeaddrinfo call
amirnik Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/pistache/mailbox.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ class Queue {

virtual ~Queue() {
while (auto *e = pop()) delete e;
delete tail;
}

template<typename U>
Expand Down
1 change: 1 addition & 0 deletions src/server/listener.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ Listener::bind(const Address& address) {
TRY(::listen(fd, backlog_));
break;
}
freeaddrinfo(addrs);
Copy link
Collaborator

@dennisjenkins75 dennisjenkins75 Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works in the common case, but will still fail to clean up resources if the "::listen()" fails 2 lines above (the 'TRY' macro will throw a different exception).

I suggest that you encapsulate 'getaddrinfo' into a RAII class so that it will clean itself up no matter how the method exits.


make_non_blocking(fd);
poller.addFd(fd, Polling::NotifyOn::Read, Polling::Tag(fd));
Expand Down