piraeus-server: deal with large backups #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rck
approved these changes
Nov 4, 2024
There is a limit of around 1MB per resource in kubernetes. Big clusters might need to make DB backups that are larger than that. We improve our current solution in two ways: * Provide a meaningful output should the run-migration not succeed. Instead of crashing by default, print what needs to be done to stderr and wait. Waiting can be skipped with an environment variable. * Try to split the backup into smaller chunks, that can be reassembled on restore. Signed-off-by: Moritz Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
improved-backup
branch
from
2bd76c2 to
ad59250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a limit of around 1MB per resource in kubernetes. Big clusters might need to make DB backups that are larger than that. We improve our current solution in two ways: