feat(minimax): add streaming word-level subtitles and simplify API #3159
+23
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add subtitle_enable parameter for streaming word-level timestamps - Remove emotion parameter and related processing logic - Keep exclude_aggregated_audio parameter as requested - Maintain backward compatibility with english_normalization deprecation - Add subtitle file processing and logging - Simplify code and remove complex validation InputParams now has 9 parameters: - language, speed, volume, pitch - english_normalization (deprecated), text_normalization - latex_read, exclude_aggregated_audio, subtitle_enable Provides streaming subtitles when subtitle_enable=True with word-level timestamps.
markbackman
reviewed
Nov 30, 2025
| if service_lang: | ||
| self._settings["language_boost"] = service_lang | ||
|
|
||
| # Add optional emotion if provided |
Contributor
There was a problem hiding this comment.
Why are you removing emotion? This feature was just added in the last release? Removing it is a breaking change. You should instead deprecate and warn about it if it's no longer relevant.
Author
There was a problem hiding this comment.
Hey markbackman, if we add emotion into the request body, the latency will be very high
markbackman
reviewed
Nov 30, 2025
| text_normalization: Enable text normalization (Chinese/English). | ||
| latex_read: Enable LaTeX formula reading. | ||
| exclude_aggregated_audio: Whether to exclude aggregated audio in final chunk. | ||
| subtitle_enable: Enable subtitle generation with word-level timestamps. |
Contributor
There was a problem hiding this comment.
Word timestamps require a broader change in this class. The subclass needs to change to reflect the change. This would become a WordTTSService and would need to implement add_word_timestamps, etc. to work with the subclass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputParams now has 9 parameters:
Provides streaming subtitles when subtitle_enable=True with word-level timestamps.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.