-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add session IDs to Gladia logs #3138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[PLA-38] missing config parameters
[GLA-2696] feat(gladia): add Gladia session id to logs for easier debug
| self._should_reconnect = True | ||
|
|
||
| def __str__(self): | ||
| return f"GladiaSTTService [{self._session_id}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all our services we log self.name to include the specific instance, so it would be better to keep the same pattern and just include the session id, like this:
| return f"GladiaSTTService [{self._session_id}]" | |
| return f"{self.name} [{self._session_id}]" |
|
@clemos, could you also add a brief description to the changelog and include a note about this log improvement? That would be great. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
I added Gladia session IDs to all logs from GladiaSTTService for easier debug