Skip to content

fix: add timeout handling for Daily room join/leave operations #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eroub wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

fix: add timeout handling for Daily room join/leave operations #3131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/pipecat/transports/daily/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@

VAD_RESET_PERIOD_MS = 2000

# Timeout constants for Daily operations
DAILY_JOIN_TIMEOUT_SECS = 30.0
DAILY_LEAVE_TIMEOUT_SECS = 30.0


@dataclass
class DailyOutputTransportMessageFrame(OutputTransportMessageFrame):
Expand Down Expand Up @@ -828,7 +832,12 @@ async def _join(self):
},
)

return await future
try:
return await asyncio.wait_for(future, timeout=DAILY_JOIN_TIMEOUT_SECS)
except asyncio.TimeoutError:
error_msg = f"Timeout joining {self._room_url} after {DAILY_JOIN_TIMEOUT_SECS}s"
logger.error(error_msg)
return (None, error_msg)

async def leave(self):
"""Leave the Daily room and cleanup resources."""
Expand Down Expand Up @@ -867,7 +876,13 @@ async def _leave(self):

future = self._get_event_loop().create_future()
self._client.leave(completion=completion_callback(future))
return await future

try:
return await asyncio.wait_for(future, timeout=DAILY_LEAVE_TIMEOUT_SECS)
except asyncio.TimeoutError:
error_msg = f"Timeout leaving {self._room_url} after {DAILY_LEAVE_TIMEOUT_SECS}s"
logger.error(error_msg)
return error_msg

def _cleanup(self):
"""Cleanup the Daily client instance."""
Expand Down