Skip to content

fix: remove broad exception swallowing in main()#18

Merged
pipe1os merged 1 commit into
mainfrom
advisor/001-remove-exception-swallowing
Jun 12, 2026
Merged

fix: remove broad exception swallowing in main()#18
pipe1os merged 1 commit into
mainfrom
advisor/001-remove-exception-swallowing

Conversation

@pipe1os

@pipe1os pipe1os commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary

Removes broad exception swallowing in the CLI entrypoint.

Motivation & Context

The main function in cli.py previously wrapped its core logic in broad except Exception as e: blocks that swallowed stack traces. This change removes those blocks to allow unexpected exceptions to surface naturally at the CLI boundary, improving debuggability by ensuring standard Python tracebacks are visible.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Documentation update

How Has This Been Tested?

Ran PYTHONPATH=src pytest to verify that no existing tests relied on the exception swallowing exit code behavior. Verified that manual errors now surface a full traceback.

  • Unit tests
  • Integration tests
  • Manual testing

Checklist

  • My code follows the code style of this project.
  • My commit messages follow the Conventional Commits format, are lowercase, imperative, and specific.
  • I have updated the documentation accordingly (if applicable).
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pipe1os pipe1os merged commit ce64d59 into main Jun 12, 2026
9 checks passed
@pipe1os pipe1os deleted the advisor/001-remove-exception-swallowing branch June 12, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant