Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC for DeploymentTrace feature #5677

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Conversation

khanhtc1202
Copy link
Member

What this PR does:

Why we need it:

This will be used as a note for DeploymentTrace feature design decision

Which issue(s) this PR fixes:

Part of #5444

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) March 17, 2025 10:19
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.66%. Comparing base (57c48c1) to head (ee8331a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5677      +/-   ##
==========================================
- Coverage   25.66%   25.66%   -0.01%     
==========================================
  Files         474      476       +2     
  Lines       50905    50894      -11     
==========================================
- Hits        13066    13063       -3     
+ Misses      36848    36841       -7     
+ Partials      991      990       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
i left some nits

khanhtc1202 and others added 2 commits March 18, 2025 18:36
Co-authored-by: Tetsuya KIKUCHI <[email protected]>
Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya KIKUCHI <[email protected]>
Signed-off-by: Khanh Tran <[email protected]>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit 2aa01ac into master Mar 19, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the add-deloymenttrace-rfc branch March 19, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants