-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RFC for DeploymentTrace feature #5677
Conversation
Signed-off-by: khanhtc1202 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5677 +/- ##
==========================================
- Coverage 25.66% 25.66% -0.01%
==========================================
Files 474 476 +2
Lines 50905 50894 -11
==========================================
- Hits 13066 13063 -3
+ Misses 36848 36841 -7
+ Partials 991 990 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
i left some nits
Co-authored-by: Tetsuya KIKUCHI <[email protected]> Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya KIKUCHI <[email protected]> Signed-off-by: Khanh Tran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Why we need it:
This will be used as a note for DeploymentTrace feature design decision
Which issue(s) this PR fixes:
Part of #5444
Does this PR introduce a user-facing change?: