Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client argument from DetermineVersions and DetermineStrategy methods #5673

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Mar 17, 2025

What this PR does:

as title

Why we need it:

Because we have this client in sdk.DetermineVersionsInput and sdk.DetermineStrategyInput.

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 25.55%. Comparing base (38a0086) to head (87dc6c8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/kubernetes/deployment/plugin.go 0.00% 2 Missing ⚠️
pkg/plugin/sdk/deployment.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5673      +/-   ##
==========================================
- Coverage   25.56%   25.55%   -0.01%     
==========================================
  Files         478      478              
  Lines       51280    51280              
==========================================
- Hits        13110    13106       -4     
- Misses      37165    37168       +3     
- Partials     1005     1006       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Warashi Warashi marked this pull request as ready for review March 17, 2025 04:44
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Warashi Warashi enabled auto-merge (squash) March 17, 2025 04:54
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Warashi Warashi merged commit f50b273 into master Mar 17, 2025
16 of 18 checks passed
@Warashi Warashi deleted the sdk-determine-methods-interface-remove-client-arg branch March 17, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants