SetConfiguration now updates ICEGatherer's servers #3339
Merged
+222
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrangelvid
force-pushed
the
fix_set_configuration
branch
from
04c1161 to
9e04d64
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3339 +/- ##
==========================================
+ Coverage 85.02% 85.12% +0.09%
==========================================
Files 80 80
Lines 9512 9532 +20
==========================================
+ Hits 8088 8114 +26
+ Misses 1001 998 -3
+ Partials 423 420 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wrangelvid
force-pushed
the
fix_set_configuration
branch
from
9e04d64 to
1607cad
Compare
Contributor
Author
|
@JoTurk thanks for getting the pion/ice PR in so quickly. This is ready for review. |
JoTurk
reviewed
Jan 9, 2026
Member
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
Changes look good to me overall, and makes us closer to the browser behavior. thank you.
icegatherer.go
Outdated
| // UpdateServers updates the ICE servers and gather policy. | ||
| // If called before gathering starts, the new servers will be used for initial gathering. | ||
| // If called after gathering has started, the new servers will be used on the next ICE restart. | ||
| func (g *ICEGatherer) UpdateServers(servers []ICEServer, policy ICETransportPolicy) error { |
wrangelvid
force-pushed
the
fix_set_configuration
branch
from
1607cad to
b31a179
Compare
JoTurk
approved these changes
Jan 9, 2026
Member
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
Cool, also thank you for updating the spec comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After using
SetConfigurationI found that the new ice servers have not been used. Turns out after creating a peer connection the ice gatherer is created with the current configuration, but it is never updated with new servers when the configuration changesThis pr should fix the issue and implement the spec properly. We just need to wait on pion/ice#866 to land.