Add test for client and peer connection address over a TCP alloc #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
🔥 thanks for this I’m terrible with spec compliance, very sloppy :( We could just put this under a OS check maybe? For platforms that support REUSE_PORT apply it in dedicated file? |
Contributor
Author
|
The test is included in #514. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For client-initiated connection requests over a TCP allocation the outbound connections made by the server MUST be locally bound to the relay transport address for the allocation. In particular, RFC 6062 Section 5.2 contains the following text:
This PR adds a check for this.
Reference issue
See #512