Exit fast recovery outside guard #454
Merged
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
==========================================
+ Coverage 83.86% 83.89% +0.02%
==========================================
Files 52 52
Lines 4060 4060
==========================================
+ Hits 3405 3406 +1
+ Misses 479 478 -1
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
force-pushed
the
move-exit-outside-guard
branch
from
d46ed84 to
ad04ae2
Compare
philipch07
approved these changes
Jan 12, 2026
Contributor
philipch07
left a comment
philipch07
left a comment
There was a problem hiding this comment.
Thanks for catching this. We really should refactor this soon... Bugs like this due to scoping errors just shouldn't exist :((
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the fast recovery exist outside of the lock, We found an issue similar to this with SCP during test but we didn't go with fixing this #438 (comment)
fixes pion/webrtc#3356