-
Notifications
You must be signed in to change notification settings - Fork 88
Use options pattern instead of config #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
JoTurk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is a good direction, we need to add more validations tho.
f888d39 to
1192971
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
- Coverage 83.79% 82.72% -1.07%
==========================================
Files 52 54 +2
Lines 4054 4145 +91
==========================================
+ Hits 3397 3429 +32
- Misses 481 539 +58
- Partials 176 177 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
124aeb4 to
32dc80b
Compare
32dc80b to
8021a05
Compare
8021a05 to
aa606bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, i think we'll just need to add test coverage and make newAssociationWithOptions public
|
^ mean making newAssociationWithOptions through new APIs to construct Client and Server. |
Description
Uses the options pattern instead of the config pattern, which is a necessary change before adding SNAP (#449).
Reference issue
Resolves #446