Skip to content

Conversation

@philipch07
Copy link
Contributor

@philipch07 philipch07 commented Dec 28, 2025

Description

Uses the options pattern instead of the config pattern, which is a necessary change before adding SNAP (#449).

Reference issue

Resolves #446

Copy link
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is a good direction, we need to add more validations tho.

@philipch07 philipch07 force-pushed the pch07/config-to-options branch from f888d39 to 1192971 Compare December 28, 2025 18:23
@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

❌ Patch coverage is 18.34862% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.72%. Comparing base (767b9c4) to head (aa606bd).

Files with missing lines Patch % Lines
association_options.go 0.00% 56 Missing ⚠️
association_rack_options.go 0.00% 26 Missing ⚠️
association.go 74.07% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   83.79%   82.72%   -1.07%     
==========================================
  Files          52       54       +2     
  Lines        4054     4145      +91     
==========================================
+ Hits         3397     3429      +32     
- Misses        481      539      +58     
- Partials      176      177       +1     
Flag Coverage Δ
go 82.72% <18.34%> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@philipch07 philipch07 force-pushed the pch07/config-to-options branch 2 times, most recently from 124aeb4 to 32dc80b Compare December 28, 2025 19:22
@philipch07 philipch07 force-pushed the pch07/config-to-options branch from 8021a05 to aa606bd Compare December 28, 2025 20:36
Copy link
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i think we'll just need to add test coverage and make newAssociationWithOptions public

@JoTurk
Copy link
Member

JoTurk commented Dec 30, 2025

^ mean making newAssociationWithOptions through new APIs to construct Client and Server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update this library to use options API

3 participants