Remove padding workaround from packetizer.GeneratePadding #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 86.87% 87.63% +0.76%
==========================================
Files 26 26
Lines 3108 3105 -3
==========================================
+ Hits 2700 2721 +21
+ Misses 350 325 -25
- Partials 58 59 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
at-wat
reviewed
Jun 10, 2025
packetizer.go
Outdated
Comment on lines
182
to
187
| // Test_TrackLocalStatic_Padding in pion/webrtc transmits 20 RTP packets with padding. | ||
| // Set both old and new PaddingSize fields alternately to test both. | ||
| if seqNum%2 == 0 { | ||
| packets[i].PaddingSize = 255 | ||
| } else { | ||
| packets[i].Header.PaddingSize = 255 |
There was a problem hiding this comment.
GeneratePadding seems be used for bandwidth estimation and not only for testing purpose, so adding a test-only change sounds not very good.
There was a problem hiding this comment.
Thanks for pointing this. I have changed this to set padding size in header only.
sirzooro
force-pushed
the
remove_padding_workaround
branch
from
6b675f8 to
a1115e8
Compare
sirzooro
force-pushed
the
remove_padding_workaround
branch
from
a1115e8 to
a023ce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is last part of fixes for pion/webrtc#2403 . It removes workaround from
packetizer.GeneratePaddingsoTest_TrackLocalStatic_Paddinginpion/webrtccan verify that bug is properly fixes. It also alternately setsPaddingSizefield inPacketandHeaderto verify that both old and new fields works.