Test fixed-point SILK reconstruction on API-rate output#111
Closed
zshang-oai wants to merge 1 commit intocodex/celt-api-rate-outputfrom
Closed
Test fixed-point SILK reconstruction on API-rate output#111zshang-oai wants to merge 1 commit intocodex/celt-api-rate-outputfrom
zshang-oai wants to merge 1 commit intocodex/celt-api-rate-outputfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (66.07%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## codex/celt-api-rate-output #111 +/- ##
==============================================================
- Coverage 82.73% 81.59% -1.14%
==============================================================
Files 21 21
Lines 4518 4717 +199
==============================================================
+ Hits 3738 3849 +111
- Misses 598 680 +82
- Partials 182 188 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RFC 6716 / 8251 conformationStatus: pass The action extracts the RFC 6716 reference implementation, applies the RFC 8251 decoder update patch, and then builds the patched reference tools. Legend: numeric cells are Inputs use the shared RFC 6716 / RFC 8251 bitstream corpus; accepted references follow RFC 8251 Section 11.
Run output |
zshang-oai
force-pushed
the
codex/celt-api-rate-output
branch
from
476e5a9 to
94dc81f
Compare
zshang-oai
force-pushed
the
codex/test-fixed-point-silk-on-pr110
branch
from
23f318e to
df9fc1e
Compare
zshang-oai
force-pushed
the
codex/celt-api-rate-output
branch
from
94dc81f to
95bfc2c
Compare
zshang-oai
force-pushed
the
codex/test-fixed-point-silk-on-pr110
branch
from
df9fc1e to
d6544f5
Compare
zshang-oai
force-pushed
the
codex/test-fixed-point-silk-on-pr110
branch
from
d6544f5 to
7d0311b
Compare
zshang-oai
force-pushed
the
codex/celt-api-rate-output
branch
from
95bfc2c to
1e4c68b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a test-only stack on top of #110. It is intentionally not intended to merge.
The main motivation of this PR is we want to see why #110's conformation is not ideal and what we can do. After many bug fixes, we realized that the last remaining piece is this repo use float point decoding on SILK and the reference implementation uses fixed-point. In theory float point is not worse, and might even be better but harness compare byte by byte. So we create this PR just to demonstrate that this implementation is on-par with reference implementation with this change.