Decode RFC 6716 CELT bands and synthesize PCM#105
Closed
zshang-oai wants to merge 1 commit intomainfrom
Closed
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (18.42%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
===========================================
- Coverage 82.85% 59.22% -23.64%
===========================================
Files 16 21 +5
Lines 2386 3750 +1364
===========================================
+ Hits 1977 2221 +244
- Misses 342 1427 +1085
- Partials 67 102 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RFC 6716 / 8251 conformationStatus: fail (informational) The action extracts the RFC 6716 reference implementation, applies the RFC 8251 decoder update patch, and then builds the patched reference tools. This check is informational while CELT support is incomplete; the workflow still reports success. Legend: numeric cells are rfc6716
rfc8251
Run output |
Contributor
Author
|
Closing in favor of a smaller PR that contains only the CELT allocation/fine-energy slice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d1c8caacontents on top of newestmain; the resulting commit hash is222ce07after resolving stack drift and lint fixes.RFC / reference notes
Validation
git diff --checkGOCACHE=/tmp/opus-go-build-cache go test ./...GOCACHE=/tmp/opus-go-build-cache go vet ./...GOCACHE=/tmp/opus-go-build-cache go test -cover ./...GOCACHE=/tmp/opus-go-build-cache golangci-lint run ./...