Decode RFC 6716 CELT TF and allocation header#104
Merged
zshang-oai merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 84.08% 84.43% +0.34%
==========================================
Files 16 16
Lines 3217 3308 +91
==========================================
+ Hits 2705 2793 +88
- Misses 447 448 +1
- Partials 65 67 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RFC 6716 / 8251 conformationStatus: fail (informational) The action extracts the RFC 6716 reference implementation, applies the RFC 8251 decoder update patch, and then builds the patched reference tools. This check is informational while CELT support is incomplete; the workflow still reports success. Legend: numeric cells are rfc6716
rfc8251
Run output |
There was a problem hiding this comment.
Pull request overview
This PR extends the CELT frame side-info decoder to cover RFC 6716’s time/frequency resolution and allocation-header fields, building on the existing coarse-energy decoding.
Changes:
- Add decoding for per-band TF changes (including optional
tf_select) and spread decision. - Add decoding for dynamic allocation boosts (bounded by RFC caps) and allocation trim.
- Add unit tests covering TF changes, spread, dynamic allocation boosts, and allocation trim.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/celt/tables.go | Adds RFC lookup tables for TF selection mapping and dynamic allocation cap bounds. |
| internal/celt/frame.go | Implements allocation-header decoding (TF changes, spread, dynamic allocation, allocation trim) and stores results in frameSideInfo. |
| internal/celt/frame_test.go | Adds targeted unit tests and supporting range-decoder test helpers for new decode paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zshang-oai
force-pushed
the
codex/celt-tf-allocation-header
branch
from
6e48800 to
f636c9b
Compare
zshang-oai
force-pushed
the
codex/celt-tf-allocation-header
branch
from
f636c9b to
9f69fe5
Compare
JoTurk
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RFC / reference notes
Validation