Skip to content

Update lint rules, force testify/assert for tests#322

Closed
Sean-Der wants to merge 1 commit into
masterfrom
testify
Closed

Update lint rules, force testify/assert for tests#322
Sean-Der wants to merge 1 commit into
masterfrom
testify

Conversation

@Sean-Der
Copy link
Copy Markdown
Member

Use testify's assert package instead of the standard library's testing package.

Use testify's assert package instead of the standard library's testing
package.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.91%. Comparing base (cbc578b) to head (968b386).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   71.91%   71.91%           
=======================================
  Files          79       79           
  Lines        4746     4746           
=======================================
  Hits         3413     3413           
  Misses       1197     1197           
  Partials      136      136           
Flag Coverage Δ
go 71.78% <ø> (ø)
wasm 69.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk
Copy link
Copy Markdown
Member

JoTurk commented Apr 23, 2025

@Sean-Der sorry i didn't see your PR before i pushed, also I didn't push this commit i did yesterday before i go to bed #323

@Sean-Der Sean-Der closed this Apr 23, 2025
@Sean-Der
Copy link
Copy Markdown
Member Author

No that’s the best news ever @joeturki im just happy we got it!

I love how much this reduces custom code. So much of the ice code was hard to read pre this change :)

@Sean-Der Sean-Der deleted the testify branch April 23, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants