Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change buffer file naming #459

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jfzunigac
Copy link
Contributor

Changing the buffer file naming to logName.dirName.fileName.buffer, which follows the watermark file naming model. This helps by:

  1. Reduce the amount of buffer files generated: the previous naming model created too many buffer files because of the uuid appended at the end.
  2. Allow S3Writers to continue from buffer file after restart in case upload fails when closing the writer
  3. Avoid multi-directory conflicts
  4. Avoid conflicts between two or more different log streams processing the same file

Other conflicts can be handled by specifying a different s3 buffer directory per log stream

Also cleaning the classes by removing unused code and tests

@jfzunigac jfzunigac requested a review from a team as a code owner December 5, 2024 02:06
@jfzunigac jfzunigac merged commit eb7d908 into pinterest:master Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants