Add simple regex-based message filtering to text reader #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffxiang
reviewed
Nov 15, 2024
singer/src/main/java/com/pinterest/singer/processor/DefaultLogStreamProcessor.java
Outdated
Show resolved
Hide resolved
singer/src/main/java/com/pinterest/singer/reader/TextLogFileReader.java
Outdated
Show resolved
Hide resolved
singer/src/main/java/com/pinterest/singer/utils/LogConfigUtils.java
Outdated
Show resolved
Hide resolved
jfzunigac
force-pushed
the
regex_based_text_filtering
branch
from
8d087d6 to
ae2ebbd
Compare
jeffxiang
approved these changes
Nov 15, 2024
yisheng-zhou
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the config
filterMessageRegexso that only messages that match the pattern provided will be returned to the processor. This does not modify the existing TextMessageReader logic, instead we leverage the headers as a DOT so that the processor knows that message should be skipped if it contains the special headerskipMessage. The skipping logic is the same as the decider based sampling logic.