Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Writer Test Fix #436

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

chesswithmihir
Copy link
Contributor

Changes

Make sure hostnames without a delimiter can still function correctly when naming AWS file format. Injecting the hostname for S3WriterTest for consistency.

@chesswithmihir chesswithmihir requested a review from a team as a code owner August 8, 2024 22:22
@chesswithmihir chesswithmihir merged commit 89eb3a8 into pinterest:master Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants