Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for passing through the ssl options #45

Closed
wants to merge 2 commits into from

Conversation

brilvio
Copy link

@brilvio brilvio commented Feb 7, 2020

Now you can pass SSL options to pino-elasticsearch and he will pass to the Client. #44

@mcollina
Copy link
Member

mcollina commented Feb 9, 2020

How is this going to be used? I think we should document it in the readme and possibly expose it to the CLI?

@brilvio
Copy link
Author

brilvio commented Feb 9, 2020

From the documentation on the js client from elasticsearch:
https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/16.x/auth-reference.html

you can pass this object

 ssl: {
    ca: fs.readFileSync('./cacert.pem'),
    rejectUnauthorized: true
  }

In my case I am passing only the rejectUnauthorized: false in the object.

I can try to expose to the CLI, tomorrow.

@mcollina
Copy link
Member

mcollina commented Feb 9, 2020 via email

@chill-cod3r
Copy link

I am also in need of this feature. Is this still being actively worked on?

@mcollina
Copy link
Member

I don't think so. Would you like to send a fresh PR?

@chill-cod3r
Copy link

Sure thing. I'm going to wrap up the other PR I have first and then would be happy to

@mcollina
Copy link
Member

Closed for no activity, feel free to reopen if you are still interested.

@mcollina mcollina closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants