[Test for AI review]*: Add enable_distance_proj to ANNQueryInfo to indicate if reading distance column from vector index #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: “EricZequan” <[email protected]>
|
|
|
/retest |
breezewish
reviewed
Feb 10, 2025
…ctor index is not built Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
breezewish
reviewed
Mar 17, 2025
Signed-off-by: “EricZequan” <[email protected]>
breezewish
reviewed
Mar 18, 2025
Signed-off-by: “EricZequan” <[email protected]>
breezewish
reviewed
Mar 19, 2025
Signed-off-by: “EricZequan” <[email protected]>
EricZequan
commented
Mar 21, 2025
Signed-off-by: “EricZequan” <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new boolean field (enable_distance_proj) to the ANNQueryInfo message to indicate whether to read a distance column from the vector index and adjusts associated field numbering and deprecation.
- Introduces enable_distance_proj to control distance projection behavior.
- Deprecates the original column_id field and adds a new ColumnInfo column field for schema metadata persistence.
- Renumbers ref_vec_f32 and index_id fields to accommodate the new fields while reserving space for future changes.
| optional uint32 hnsw_ef_search = 20 [(gogoproto.nullable) = false]; // Only for HNSW indexes | ||
|
|
||
| // If enabled, the content of TableScan's vector output column (whose ID is column.id) will be removed and | ||
| // TableScan will read an distance column (whose id must be -2000) as replacement, tiflash persistent layer |
There was a problem hiding this comment.
Typographical error: 'an distance column' should be 'a distance column'.
Suggested change
| // TableScan will read an distance column (whose id must be -2000) as replacement, tiflash persistent layer | |
| // TableScan will read a distance column (whose id must be -2000) as replacement, tiflash persistent layer |
Copilot uses AI. Check for mistakes.
| optional uint32 hnsw_ef_search = 20 [(gogoproto.nullable) = false]; // Only for HNSW indexes | ||
|
|
||
| // If enabled, the content of TableScan's vector output column (whose ID is column.id) will be removed and | ||
| // TableScan will read an distance column (whose id must be -2000) as replacement, tiflash persistent layer |
There was a problem hiding this comment.
[nitpick] Typographical error: 'tiflash' should likely be 'TiFlash' to match standard capitalization.
Suggested change
| // TableScan will read an distance column (whose id must be -2000) as replacement, tiflash persistent layer | |
| // TableScan will read an distance column (whose id must be -2000) as replacement, TiFlash persistent layer |
Copilot uses AI. Check for mistakes.
| optional string column_name = 4 [(gogoproto.nullable) = false]; // For debug purpose only. Currently only used in explain. | ||
| optional int64 column_id = 5 [(gogoproto.nullable) = false]; | ||
| // deprecated field, we use column to get the id first, and this field will not be set again. | ||
| // Retain this field to be compatible with older versions of tidb |
There was a problem hiding this comment.
[nitpick] Typographical error: 'tidb' should be capitalized as 'TiDB'.
Suggested change
| // Retain this field to be compatible with older versions of tidb | |
| // Retain this field to be compatible with older versions of TiDB |
Copilot uses AI. Check for mistakes.
|
This PR is used for large model review and testing. New PR are moved to: #358 |
EricZequan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref pingcap/tidb#54245
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn: