Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): fix incorrect default value for the not null timestamp field in the Debezium protocol #11976

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Jan 6, 2025

What problem does this PR solve?

Issue Number: close #11966

What is changed and how it works?

Follow the official document https://debezium.io/documentation/reference/3.0/connectors/mysql.html#mysql-temporal-types.

  • For TIMESTAMP columns whose default value is specified as CURRENT_TIMESTAMP or NOW, the value 1970-01-01 00:00:00 is used as the default value.
  • MySQL allows zero-values for DATE, DATETIME, and TIMESTAMP columns because zero-values are sometimes preferred over null values. The MySQL connector represents zero-values as null values when the column definition allows null values, or as the epoch day when the column does not allow null values.

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 6, 2025
@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 6, 2025

/retest

Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-06 03:29:34.621055168 +0000 UTC m=+151517.909886873: ☑️ agreed by 3AceShowHand.
  • 2025-01-06 07:03:14.214096264 +0000 UTC m=+164337.502927970: ☑️ agreed by hongyunyan.

@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 6, 2025

/retest

@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 7, 2025

/retest

4 similar comments
@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 7, 2025

/retest

@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 7, 2025

/retest

@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 8, 2025

/retest

@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 8, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit a4552cb into pingcap:master Jan 8, 2025
26 checks passed
@ti-chi-bot
Copy link
Member

@wk989898: cannot checkout 8.1: error checking out 8.1: exit status 1. output: error: pathspec '8.1' did not match any file(s) known to git

In response to this:

/cherry-pick 8.5
/cherry-pick 8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 8, 2025

/cherry-pick release-8.5
/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@wk989898: cannot checkout 8.5: error checking out 8.5: exit status 1. output: error: pathspec '8.5' did not match any file(s) known to git

In response to this:

/cherry-pick 8.5
/cherry-pick 8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 8, 2025
@ti-chi-bot
Copy link
Member

@wk989898: new pull request created to branch release-8.1: #11990.

In response to this:

/cherry-pick release-8.5
/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wk989898: new pull request created to branch release-8.5: #11991.

In response to this:

/cherry-pick release-8.5
/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][CDC]Debezium Protocal set error default value for the not null timestamp field.
4 participants