Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): add parameter to enable watermark events in the Debezium protocol #11877

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

wk989898
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #11876

What is changed and how it works?

We use EnableTiDBExtension to control whether to encode watermark event. After that, it will be up to users to set.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2024
@wk989898
Copy link
Collaborator Author

/retest

3 similar comments
@wk989898
Copy link
Collaborator Author

/retest

@wk989898
Copy link
Collaborator Author

/retest

@wk989898
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-03 02:29:29.658103102 +0000 UTC m=+663105.014107672: ☑️ agreed by hongyunyan.
  • 2025-01-03 02:35:23.552466935 +0000 UTC m=+663458.908471470: ☑️ agreed by 3AceShowHand.

@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 3, 2025

/retest

1 similar comment
@wk989898
Copy link
Collaborator Author

wk989898 commented Jan 4, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1dd87cf into pingcap:master Jan 4, 2025
27 checks passed
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2025

@wk989898: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test 9561680 link unknown /test pull-dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding behavior of watermark events in the Debezium protocol
3 participants