-
Notifications
You must be signed in to change notification settings - Fork 6.1k
bindinfo: add last_used_date to track bindinfo usage frequency (#63409) #63824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
bindinfo: add last_used_date to track bindinfo usage frequency (#63409) #63824
Conversation
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@hawkingrei This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #63824 +/- ##
================================================
Coverage ? 77.2261%
================================================
Files ? 1654
Lines ? 455175
Branches ? 0
================================================
Hits ? 351514
Misses ? 82186
Partials ? 21475
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
1 similar comment
|
/retest |
|
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
3092139 to
e2016e7
Compare
|
/unhold |
|
/approve |
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
yudongusa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open doc PR on this
|
/retest |
Please create a doc PR here. |
BornChanger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
br side lgtm.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, D3Hunter, hawkingrei, Leavrth, qw4990, you06, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #63409
cherry-pick of #60296
What problem does this PR solve?
Issue Number: close #63407
Problem Summary:
What changed and how does it work?
Currently, some customers have created a large number of bindings. However, it is difficult to determine whether these bindings are still in use. The sheer volume of bindings also puts pressure on TiDB. Therefore, we need a way to identify and mark the bindings that are not in use.
Check List
Tests
start a tidb with master which is started by script.
TikvandPDis started bytiup playground nightly --mode tikv-slim.kill this TiDB and start changed tidb verson.
BTW
The code in this area still differs from that on the master branch, which may lead to performance issues. The difference lies in the fact that version 8.5 requires an additional memory setting operation. However, from what we can see on the profiler
According to the flame graph, this part only accounts for 0.1% of the total query cost. Therefore, one additional set operation is roughly equivalent to the cost of one get operation, making the overall impact very limited.
I add a benchmark for binding. The overhead here is less than 3%. The overhead of TiKV has not been taken into account here. This part only ran the
EXPLAINcommand and did not execute the query.before
after
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.