test: [DNM] Test test task manager entry size by mjonss · Pull Request #61222 · pingcap/tidb

mjonss · 2025-05-20T12:31:50Z

What problem does this PR solve?

Issue Number: close #60239

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…erEntrySize

ti-chi-bot · 2025-05-20T12:31:53Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

ti-chi-bot · 2025-05-20T12:31:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

pkg/disttask/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mjonss · 2025-05-20T12:32:12Z

/retest

tiprow · 2025-05-20T12:32:20Z

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mjonss · 2025-05-20T12:48:36Z

/retest

codecov · 2025-05-20T13:06:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.2972%. Comparing base (07f4eda) to head (a19aa9a).
⚠️ Report is 1037 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #61222        +/-   ##
================================================
+ Coverage   73.1487%   77.2972%   +4.1485%     
================================================
  Files          1726       1851       +125     
  Lines        478033     566831     +88798     
================================================
+ Hits         349675     438145     +88470     
+ Misses       106932     106500       -432     
- Partials      21426      22186       +760

Flag	Coverage Δ
integration	`42.5167% <ø> (?)`
unit	`76.8415% <ø> (+4.4592%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9532% <ø> (+0.1728%)`	⬆️
parser	`∅ <ø> (∅)`
br	`50.4091% <ø> (+2.8448%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mjonss · 2025-05-20T13:37:41Z

/test unit_test

ti-chi-bot · 2025-05-20T13:37:45Z

@mjonss: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-next-gen-real-tikv-test

/test pull-sqllogic-test

/test pull-tiflash-test

/test pull-vector-search-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

Details

In response to this:

/test unit_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-05-20T13:38:04Z

@mjonss: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test unit_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-05-20T13:38:07Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

@mjonss: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-next-gen-real-tikv-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test pull-vector-search-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test unit_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mjonss · 2025-05-20T13:38:12Z

/test unit-test

tiprow · 2025-05-20T13:38:35Z

@mjonss: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mjonss · 2025-05-20T14:03:47Z

/test unit-test

tiprow · 2025-05-20T14:04:09Z

@mjonss: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mjonss · 2025-05-21T07:32:36Z

/retest

tiprow · 2025-05-21T08:27:54Z

@mjonss: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	`a19aa9a`	link	true	`/test fast_test_tiprow`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

D3Hunter and others added 3 commits March 24, 2025 18:12

fix

47b4ed6

for debug

1122f85

Merge remote-tracking branch 'pingcap/master' into test-TestTaskManag…

e54fa8f

…erEntrySize

ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 20, 2025

ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2025

mjonss added ok-to-test Indicates a PR is ready to be tested. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2025

Changed to t.Logf, which works when debugging

cb0d132

ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2025

minor change to trigger new tests

a19aa9a

mjonss closed this Nov 18, 2025

mjonss deleted the test-TestTaskManagerEntrySize branch November 18, 2025 23:09

Conversation

mjonss commented May 20, 2025

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot Bot commented May 20, 2025

Uh oh!

ti-chi-bot Bot commented May 20, 2025

Uh oh!

mjonss commented May 20, 2025

Uh oh!

tiprow Bot commented May 20, 2025

Uh oh!

mjonss commented May 20, 2025

Uh oh!

codecov Bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mjonss commented May 20, 2025

Uh oh!

ti-chi-bot Bot commented May 20, 2025

Uh oh!

tiprow Bot commented May 20, 2025

Uh oh!

tiprow Bot commented May 20, 2025

Uh oh!

mjonss commented May 20, 2025

Uh oh!

tiprow Bot commented May 20, 2025

Uh oh!

mjonss commented May 20, 2025

Uh oh!

tiprow Bot commented May 20, 2025

Uh oh!

mjonss commented May 21, 2025

Uh oh!

tiprow Bot commented May 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented May 20, 2025 •

edited

Loading