Backup: remove improper memory usage during full backup (#58591)#59500
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #59500 +/- ##
================================================
Coverage ? 58.9105%
================================================
Files ? 1777
Lines ? 654048
Branches ? 0
================================================
Hits ? 385303
Misses ? 244095
Partials ? 24650
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test unit-test |
|
@3pointer: No presubmit jobs available for pingcap/[email protected] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/test unit-test |
|
@3pointer: No presubmit jobs available for pingcap/[email protected] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/test unit-test |
|
@3pointer: No presubmit jobs available for pingcap/[email protected] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test unit-test |
|
@3pointer: No presubmit jobs available for pingcap/[email protected] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test unit-test //pkg/session:session_test not stable |
|
@3pointer: No presubmit jobs available for pingcap/[email protected] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
1 similar comment
|
/retest |
This is an automated cherry-pick of #58591
What problem does this PR solve?
Issue Number: close #58587
Problem Summary:
When performing a full backup on millions of tables, the default incomplete range buffer grows significantly due to the large number of ranges. Since most ranges are complete, a lower buffer value should be used to optimize memory usage.
What changed and how does it work?
Set default incomplete to a lower value.
Check List
Tests
Manually Backup millions of tables
Before this PR, the inuse memory consume 4GB with GetIncompleteRanges
After the memory usage reduced.

Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.