-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix incorrectly using the schema for plan cache (#57964) #58090
planner: fix incorrectly using the schema for plan cache (#57964) #58090
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #58090 +/- ##
================================================
Coverage ? 57.1328%
================================================
Files ? 1773
Lines ? 629183
Branches ? 0
================================================
Hits ? 359470
Misses ? 245576
Partials ? 24137
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test all |
@wuhuizuo: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #57964
What problem does this PR solve?
Issue Number: close #56733
Problem Summary:
If the table ID is changed for a given table name, the plan cache key is not updated.
For an insert statement, it may use the outdated schema, resulting in incorrect data or query results.
What changed and how does it work?
Make sure the
tbl
is updated in function planCachePreprocess() if tableByID doesn't return the table info.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.